Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHubs: Fix Span links on send #28951

Merged
merged 5 commits into from
May 23, 2022
Merged

Conversation

lmolkova
Copy link
Member

@lmolkova lmolkova commented May 19, 2022

Fixing context population on send span.
OTelTracer expects to see SpanContext instance under span-context key and instead it gets two nested span-context keys:

  • com.azure.utils.Context[span-context]:
    • com.azure.utils.Context[span-context] : SpanContext

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@lmolkova
Copy link
Member Author

/cc @trask

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@conniey conniey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the CHANGELOG.md with your changes?

Thanks so much!

@lmolkova lmolkova merged commit 490aed4 into Azure:main May 23, 2022
anushkasingh16 pushed a commit to anushkasingh16/azure-sdk-for-java that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants